sadpandajoe commented on code in PR #43502:
URL: https://github.com/apache/superset/pull/43502#discussion_r3857482021
##########
.github/workflows/testcontainers.yml:
##########
@@ -0,0 +1,91 @@
+# db_engine_specs tests against real databases (testcontainers)
+name: Testcontainers
+
+# Spins up real Docker containers (see tests/testcontainers/ for the current
+# dialect list) via testcontainers-python, which catches real dialect/driver
+# regressions -- the kind mocked db_engine_specs unit tests structurally
+# cannot, e.g. apache/superset#42899 (Trino emitting OFFSET before LIMIT).
+# Runs on a nightly cron (catches drift from a driver's own releases, not
+# just from Superset's changes) and on pull_request, scoped via `paths` to
+# only PRs that actually touch this test suite or the workflow itself, so
+# unrelated PRs across the repo are never affected.
+permissions:
+ contents: read
+
+on:
+ schedule:
+ - cron: "0 5 * * *"
+ workflow_dispatch: {}
+ pull_request:
+ paths:
+ - ".github/workflows/testcontainers.yml"
+ - "tests/testcontainers/**"
+
+concurrency:
Review Comment:
This group is shared by every PR run and the nightly run, while
`cancel-in-progress` is enabled. Starting the workflow on another PR can
therefore cancel an in-progress run for this PR (or the nightly drift check),
leaving it without a result. Should the group include the PR/run identity so
independent runs do not cancel each other?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
