sadpandajoe commented on code in PR #43502: URL: https://github.com/apache/superset/pull/43502#discussion_r3857509547
########## UPDATING.md: ########## @@ -25,6 +25,7 @@ assists people when migrating to a new version. ## Next - `SAMPLES_ROW_LIMIT` is now the default for `/datasource/samples` requests without a valid explicit `per_page`, rather than a hard per-request ceiling; explicit limits are honored up to the existing global row-limit ceiling, matching `/chart/data` SAMPLES requests. +- The `cockroachdb` extra (`pip install apache-superset[cockroachdb]`) now installs `sqlalchemy-cockroachdb` instead of the abandoned `cockroachdb` package, whose SQLAlchemy dialect could not be imported under SQLAlchemy 2.0. Existing environments with the old package installed should `pip uninstall cockroachdb && pip install sqlalchemy-cockroachdb` (or simply reinstall the extra) to restore CockroachDB connectivity. Review Comment: Reinstalling the extra does not remove the old differently named `cockroachdb` distribution. It can leave both packages registering the `cockroachdb` SQLAlchemy dialect entry point, so an upgraded environment may still load the abandoned implementation. Should the migration require uninstalling `cockroachdb` rather than presenting reinstalling the extra as an alternative? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
