sadpandajoe commented on code in PR #43502: URL: https://github.com/apache/superset/pull/43502#discussion_r3857502572
########## requirements/development.in: ########## @@ -16,5 +16,8 @@ # specific language governing permissions and limitations # under the License. # --e .[development,bigquery,druid,duckdb,fastmcp,gevent,gsheets,mysql,postgres,presto,prophet,trino,thumbnails] +-e .[development,bigquery,cockroachdb,crate,db2,druid,duckdb,elasticsearch,fastmcp,gevent,gsheets,mssql,mysql,oracle,postgres,presto,prophet,trino,thumbnails] -e ./superset-extensions-cli[test] +# testcontainers-backed db_engine_specs tests (tests/testcontainers/) -- +# see .github/workflows/testcontainers.yml +testcontainers[cockroachdb,cratedb,db2,mssql,oracle,trino]>=4.15.0,<5 Review Comment: Installing the normal development environment now makes every testcontainers module importable, and pytest discovers all of `tests/`; a plain repository `pytest` therefore starts these Docker-only suites instead of leaving them nightly-only. That makes the standard suite fail on Dockerless or documented unsupported platforms. Should these dependencies/tests be behind an explicit opt-in marker or environment guard? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
