pchukwuemeka424 opened a new pull request, #43536:
URL: https://github.com/apache/superset/pull/43536

   ### SUMMARY
   Fixes #43089.
   
   Settings → Info always links to `/user_info/`, but `UserInfoView` required 
`can_read on user` / `User`. That view-menu is Admin-only 
(`ADMIN_ONLY_VIEW_MENUS`), so Alpha/Gamma were redirected to 
`/superset/welcome/` while Admin worked.
   
   This binds the SPA shell to `can_userinfo on UserInfo`. `can_userinfo` is 
already in `ACCESSIBLE_PERMS`, so stock Gamma and Alpha receive it on role sync 
without widening user-management access.
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   N/A (permission / redirect behavior).
   
   ### TESTING INSTRUCTIONS
   1. Log in as Alpha or Gamma (not Admin).
   2. Open **Settings → Info**.
   3. Confirm `/user_info/` loads the profile page instead of redirecting to 
`/superset/welcome/`.
   4. Confirm Admin still reaches `/user_info/` and user-management (`User`) 
remains Admin-only.
   5. After upgrade, ensure roles are synced (`superset init` / normal startup 
sync) so `can_userinfo on UserInfo` is granted to Gamma/Alpha.
   
   Unit coverage: `tests/unit_tests/views/test_user_info_permissions.py`.
   Integration assertion: Gamma includes `("can_userinfo", "UserInfo")` in 
`tests/integration_tests/security_tests.py`.
   
   ### ADDITIONAL INFORMATION
   - [x] Has associated issue: #43089
   - [ ] Required feature flags:
   - [ ] Changes UI
   - [ ] Includes DB Migration (follow approval process in 
[SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   
   Made with [Cursor](https://cursor.com)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to