sadpandajoe commented on code in PR #43536: URL: https://github.com/apache/superset/pull/43536#discussion_r3878625216
########## tests/unit_tests/views/test_user_info_permissions.py: ########## @@ -0,0 +1,58 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +"""Permissions for the Settings → Info (/user_info/) page.""" + +from unittest.mock import MagicMock + +from superset.security.manager import SupersetSecurityManager +from superset.views.user_info import UserInfoView + + +def test_user_info_view_uses_accessible_userinfo_permission() -> None: Review Comment: These assertions prove the decorator metadata and the role's PVM membership, but not the endpoint's FAB access check, so a registration or authorization mismatch could still redirect the Gamma/Alpha users this change targets. Could this add an authenticated Gamma/Alpha request to `/user_info/` that asserts `200`? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
