codeant-ai-for-open-source[bot] commented on code in PR #43536:
URL: https://github.com/apache/superset/pull/43536#discussion_r3860200946
##########
superset/views/user_info.py:
##########
@@ -24,11 +24,21 @@
class UserInfoView(BaseSupersetView):
+ """SPA shell for the signed-in user's own profile page.
+
+ Uses ``can_userinfo on UserInfo`` rather than ``can_read on user`` /
+ ``User``. The latter is Admin-only (``ADMIN_ONLY_VIEW_MENUS``), so
+ Alpha/Gamma were redirected to ``/superset/welcome/`` when opening
+ Settings → Info even though the menu link is shown to every
+ authenticated user. ``can_userinfo`` is already in
+ ``ACCESSIBLE_PERMS``, so stock Gamma and Alpha receive it on role sync.
+ """
+
route_base = "/"
- class_permission_name = "user"
+ class_permission_name = "UserInfo"
Review Comment:
**Suggestion:** Changing the view-menu to `UserInfo` creates a new
permission target, but existing custom roles that were granted the previous
UserInfo endpoint permission will not receive or retain access to this new PVM.
After upgrading and syncing, those users can be denied access to `/user_info/`.
Preserve the legacy permission during migration or make the authorization
accept the old target as a compatibility path. [api mismatch]
<details>
<summary><b>Severity Level:</b> Major ⚠️</summary>
```mdx
- ❌ Existing custom roles may lose Settings → Info access.
- ⚠️ Stock Alpha/Gamma roles receive the new permission.
- ⚠️ User-management permissions remain unaffected.
```
</details>
[](https://docs.codeant.ai/cli/resolve-pr-comments-skill)
[](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=434ca0d4d19b4e4a8ed0423b831838e9&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
[](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=434ca0d4d19b4e4a8ed0423b831838e9&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
<details>
<summary><b>Prompt for AI Agent 🤖 </b></summary>
```mdx
This is a comment left during a code review.
**Path:** superset/views/user_info.py
**Line:** 38:38
**Comment:**
*Api Mismatch: Changing the view-menu to `UserInfo` creates a new
permission target, but existing custom roles that were granted the previous
UserInfo endpoint permission will not receive or retain access to this new PVM.
After upgrading and syncing, those users can be denied access to `/user_info/`.
Preserve the legacy permission during migration or make the authorization
accept the old target as a compatibility path.
Validate the correctness of the flagged issue. If correct, How can I resolve
this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask
user if the user wants to fix the rest of the comments as well. if said yes,
then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
<a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F43536&comment_hash=f08b9e2d04249b05df7e5945017d674986b05b412cebd9aa2e63e763b2cc3e0e&reaction=like'>👍</a>
| <a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F43536&comment_hash=f08b9e2d04249b05df7e5945017d674986b05b412cebd9aa2e63e763b2cc3e0e&reaction=dislike'>👎</a>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
