bito-code-review[bot] commented on PR #43701:
URL: https://github.com/apache/superset/pull/43701#issuecomment-5473531703
<!-- Bito Reply -->
The flagged race condition is a valid concern. When `patchRows` is called
outside the protection of `latestRequestIdRef`, an asynchronous response from
an older request can arrive after a newer request has already completed,
leading to stale data being merged into the state.
To resolve this, you should ensure that `patchRows` only processes results
if the request ID matches the current `latestRequestIdRef`. You can implement
this by capturing the current request ID at the start of the operation and
checking it before applying the results:
```typescript
const requestId = latestRequestIdRef.current;
const result = await patchRows(...);
if (requestId === latestRequestIdRef.current) {
// Apply the result
}
```
I have reviewed the available PR context. There are no other comments in the
provided `pr_comments.csv` file to address. Please let me know if you would
like me to investigate further or if you have additional questions.
**superset-frontend/src/views/CRUD/hooks.ts**
```
const requestId = latestRequestIdRef.current;
const result = await patchRows(...);
if (requestId === latestRequestIdRef.current) {
// Apply the result
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
