codeant-ai-for-open-source[bot] commented on code in PR #43701:
URL: https://github.com/apache/superset/pull/43701#discussion_r3891617747
##########
superset/tasks/decorators.py:
##########
@@ -513,6 +513,10 @@ def _execute_inline(
with use_context(ctx):
self.func(*args, **kwargs)
+ # The work finished; stop the abort listener from flipping this to
+ # ABORTED if a cancel signal lands now (mirrors the async
executor).
+ ctx.mark_execution_completed()
Review Comment:
**Suggestion:** A timeout can fire after `mark_execution_completed()` but
before cleanup, setting `timeout_triggered` and aborting already-finished work
instead of leaving it successful. [race condition]
**Assessment:** ๐ `Major` ยท ๐ `Occurrence: Sometimes`
[](https://docs.codeant.ai/cli/resolve-pr-comments-skill)
[](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=67a46cd58b024f7fb3732cc4f5cdeca3&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
[](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=67a46cd58b024f7fb3732cc4f5cdeca3&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
<details>
<summary><b>Prompt for AI Agent ๐ค </b></summary>
```mdx
This is a comment left during a code review.
**Path:** superset/tasks/decorators.py
**Line:** 518:518
**Comment:**
*Race Condition: A timeout can fire after `mark_execution_completed()`
but before cleanup, setting `timeout_triggered` and aborting already-finished
work instead of leaving it successful.
Validate the correctness of the flagged issue. If correct, How can I resolve
this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask
user if the user wants to fix the rest of the comments as well. if said yes,
then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
<a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F43701&comment_hash=5ecad3f62187c1e083ee4c2bbeb909a6db454348af9704745e0d2ea6adcc8da7&reaction=like'>๐</a>
| <a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F43701&comment_hash=5ecad3f62187c1e083ee4c2bbeb909a6db454348af9704745e0d2ea6adcc8da7&reaction=dislike'>๐</a>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
