villebro commented on PR #43701:
URL: https://github.com/apache/superset/pull/43701#issuecomment-5473780315
Found and fixed the real CI cause in `733b8e3` — it was mine, and broader
than the flaky test.
**Root cause: `asyncEvent` failed to *load*.** `init()` runs at module load
and I had added `wsEnabled = Boolean(config.WEBSOCKET_ENABLE)` **before** the
feature-flag gate. In test suites with no `data-bootstrap`,
`getBootstrapData().common.conf` is `undefined`, so `config.WEBSOCKET_ENABLE`
threw `Cannot read properties of undefined` at import — failing **every test
file that transitively imports `asyncEvent`**, which is why it hit many shards
rather than my three test files. Fixed by reading it defensively
(`config?.WEBSOCKET_ENABLE`), plus a regression test asserting `init()` with no
conf doesn't throw. Reproduced the exact failing shards locally (`jest
--shard=N/8`) — shards 2 and 7 are now clean.
**Remaining two failures are pre-existing / flaky, not from this PR:**
- `src/pages/DashboardList/DashboardList.behavior.test.tsx` ("opens delete
confirmation from list view trash icon") fails **2/2 runs on the base
`gaq-to-gtf`** as well — a jsdom `getComputedStyle` "Not implemented"
limitation, unrelated to these changes. Per the repo guidance I'm leaving it
out of this PR (it should be fixed on a separate branch).
- `tools/webpack.proxy-config.test.js` (zstd/gzip proxy decompression +
connection-drop timeouts) is a flaky timeout — it passed on re-run and is
unrelated to the GTF work.
Verified locally: `jest --shard=2/8` and `--shard=7/8` fully green;
`src/middleware`, `src/views/CRUD`, `src/views`, and the previously-crashing
`SaveModal` / `useExploreAdditionalActionsMenu` / `SliceHeaderControls` suites
all pass.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
