bito-code-review[bot] commented on PR #43724:
URL: https://github.com/apache/superset/pull/43724#issuecomment-5481533692
<!-- Bito Reply -->
The pull request introduces a mechanism to prevent XSS or injection
vulnerabilities by ensuring that exception text is properly handled and that
destructive actions (like purging an archived dataset) are gated by a confirmed
impact token. The changes include updates to the `DeleteModal` component to
support `loading` states, independent button disabling, and a
`confirmationResetKey` to re-arm the type-to-confirm gate when the impact
payload changes. These updates ensure that users cannot proceed with
destructive actions while dependencies are being calculated or if the impact
has changed since the confirmation was initially displayed.
**superset-frontend/packages/superset-ui-core/src/components/DeleteModal/index.tsx**
```
const onPressEnter = () => {
if (!disableChange && !disablePrimaryButton && !loading) {
confirm();
}
};
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
