codeant-ai-for-open-source[bot] commented on code in PR #43724:
URL: https://github.com/apache/superset/pull/43724#discussion_r3897554135
##########
superset/commands/deletion_retention/purge_cascade.py:
##########
@@ -241,15 +248,22 @@ def cascade_hard_delete(
if session.execute(claim.with_for_update()).scalar_one_or_none()
is None:
raise PurgeRaceLostError
+ if entity_type == "dataset" and confirmed_impact_token is not None:
+ confirmed_impact = collect_dataset_purge_impact(session,
entity_id)
+ if confirmed_impact.impact_token != confirmed_impact_token:
+ raise PurgeImpactChangedError(confirmed_impact)
Review Comment:
✅ **Customized review instruction saved!**
**Instruction:**
> Do not flag post-claim chart-writer race conditions that would require
globally serializing chart/dashboard writers; this purge contract intentionally
uses submit-time and locked dataset-row rechecks, and post-claim inserts may
remain orphaned under non-cascade deletion.
**Applied to:**
- `superset/commands/deletion_retention/purge_cascade.py`
---
💡 *To manage or update this instruction, visit: [CodeAnt AI
Settings](https://app.codeant.ai/org/settings/learnings)*
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
