mikebridge commented on PR #43724: URL: https://github.com/apache/superset/pull/43724#issuecomment-5483207599
Follow-up pushed as 25781a051a: - **CI reds fixed**: all three integration lanes failed on `test_open_api_spec` because `GET /<uuid>/purge-impact` lacked an OpenAPI operation block (an operation without `responses` fails spec validation). The contract is now documented, referencing `DatasetPurgeImpactSchema`. - **CodeAnt (modal close during submit)**: valid — fixed; success toast and list refresh no longer depend on the modal still being open. Regression test included. - **CodeAnt (post-lock chart inserts)**: by design — replied on the thread with the two-recheck contract rationale. - **CodeQL (exception text as HTML)**: impact entries now only render links for server-issued application paths (`/`-prefixed, not scheme-relative); everything else renders as plain text, with a test. _Comment generated by Claude (AI) on behalf of @mikebridge._ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
