ShauryaaIBM commented on PR #43762: URL: https://github.com/apache/superset/pull/43762#issuecomment-5494697953
Addressed all CodeAnt review findings in latest commit 6366a1486f: 1. Empty dashboard deadlock — PRINT_ALL_CHART_HOLDERS_READY_JS now returns true immediately when there are no chart holders (markdown-only dashboard). Dropped holders.length > 0 gate. 2. ECharts blank canvas — Same fix reuses UNREADY_ALL_CHART_HOLDERS_JS_BODY which already excludes unpainted ECharts hosts via ECHARTS_UNPAINTED_HOST_SELECTOR. 3. Context resource leak — browser.new_context() / auth() / new_page() now inside a try/except that closes the context on any setup failure. 4. Reserved URL params — Added print, print_font_size, print_layout, print_orientation to RESERVED_DASHBOARD_URL_PARAMS so permalinks don't capture print-mode state. 5. Header center slot — Added the missing center input to the PDF header section in AlertReportModal. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
