sadpandajoe commented on code in PR #43762:
URL: https://github.com/apache/superset/pull/43762#discussion_r3928794420
##########
superset/utils/screenshots.py:
##########
@@ -196,31 +178,13 @@ def is_computing_stale(self) -> bool:
datetime.now() - datetime.fromisoformat(self.get_timestamp())
).total_seconds() >= computing_ttl
- def should_trigger_task(
- self, force: bool = False, expected_scope: str | None = None
- ) -> bool:
- """
- :param expected_scope: The scope (e.g. "dashboard:<id>") the caller
- requires this entry to carry. Entries written before scope
- tracking existed -- or by a stale/mismatched caller -- deserialize
- with no scope (or a different one) and are otherwise
- indistinguishable from a fresh, valid ``UPDATED`` entry, which
- would leave them permanently un-refreshed: the scope check at
- read time rejects them, but nothing ever re-triggers computation.
- Treat a scope mismatch on an ``UPDATED`` entry as a cache miss so
- it gets recomputed and re-scoped.
- """
+ def should_trigger_task(self, force: bool = False) -> bool:
Review Comment:
This removes `expected_scope` and `get_scope`, but the current chart and
dashboard thumbnail endpoints still call both APIs. Requests that need a
thumbnail will now raise `TypeError` (and later `AttributeError`) instead of
returning a cached image or scheduling rendering; can this compatibility change
be updated together with its callers?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
