ShauryaaIBM commented on PR #43762:
URL: https://github.com/apache/superset/pull/43762#issuecomment-5495499559
Addressed all Bito and CodeAnt review findings in latest commit 4830d48389:
CodeAnt findings (from previous push 6366a14 / 12c1b34):
1. Empty dashboard deadlock — PRINT_ALL_CHART_HOLDERS_READY_JS now returns
true immediately when there are no chart holders. Dropped holders.length > 0
gate.
2. ECharts blank canvas — same fix reuses UNREADY_ALL_CHART_HOLDERS_JS_BODY
which already excludes unpainted ECharts hosts via
ECHARTS_UNPAINTED_HOST_SELECTOR.
3. Playwright context resource leak — browser.new_context() / auth() /
new_page() now inside a try/except that closes the context on any setup failure.
4. Print params not reserved — added print, print_font_size, print_layout,
print_orientation to RESERVED_DASHBOARD_URL_PARAMS.
5. PDF header center slot — added the missing center input to the PDF header
section in AlertReportModal.
6. AlertReportsRetry flag guard — restored &&
isFeatureEnabled(FeatureFlag.AlertReportsRetry) on the error-handling panel.
Bito findings (latest push 4830d48389):
1. slice-header class removed — restored className="slice-header" on
ChartHeaderStyles in SliceHeader/index.tsx. Fixes SliceHeader.test.tsx:232 and
the fullscreen CSS rule.
2. include_cta removed — restored default value, submit payload, and
checkbox UI in AlertReportModal. Fixes 5 existing tests in
AlertReportModal.test.tsx.
3. KeyError on WEBDRIVER_TYPE — reverted spurious changes to BaseScreenshot
in screenshots.py. The driver_type property and Selenium fallback were not in
upstream master; BaseScreenshot.driver() is restored to return
WebDriverPlaywright("", window_size). DashboardPrintScreenshot.get_print_pdf()
now passes "" as the unused first arg directly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
