dpreuss opened a new pull request, #43793:
URL: https://github.com/apache/superset/pull/43793
### SUMMARY
When `GLOBAL_ASYNC_QUERIES` is enabled, `/api/v1/chart/data` often returns
**HTTP 202** with a job id instead of synchronous `result[0].data`.
`AlertReportModal` was reading `response.json.result[0].data` directly from
`getChartDataRequest`, so selecting a **Dashboard Filter** never populated
`optionFilterValues` and the **Value** control stayed disabled/greyed out.
This change routes those responses through `handleChartDataResponse` (same
pattern as Drill By), which awaits async results via `waitForAsyncData` when
status is 202.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
N/A (behavior fix; Value dropdown enables after filter options load)
### TESTING INSTRUCTIONS
1. Enable feature flags:
- `ALERT_REPORTS=True`
- `ALERT_REPORTS_FILTER=True`
- `GLOBAL_ASYNC_QUERIES=True`
2. Open **Alerts & Reports** → create/edit a report
3. Content type = **Dashboard**, pick a dashboard with native filters
4. Select a dashboard filter
5. Confirm **Value** becomes enabled and lists options (may take a moment
for the async query)
6. Also smoke-test with `GLOBAL_ASYNC_QUERIES=False` to confirm sync path
still works
Unit tests: update `getChartDataRequest` mocks to include `response: {
status: 200 }` so the GAQ branch of `handleChartDataResponse` is satisfied
under the suite's `isFeatureEnabled: () => true` mock.
### ADDITIONAL INFORMATION
- [x] Has associated issue: discovered while enabling `ALERT_REPORTS_FILTER`
with GAQ on Superset 6.1.0
- [ ] Required feature flags: `ALERT_REPORTS`, `ALERT_REPORTS_FILTER` (bug
only surfaces with `GLOBAL_ASYNC_QUERIES`)
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in
[SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
Made with [Cursor](https://cursor.com)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
