dpreuss commented on code in PR #43793:
URL: https://github.com/apache/superset/pull/43793#discussion_r3916334987
##########
superset-frontend/src/features/alerts/AlertReportModal.tsx:
##########
@@ -759,35 +762,35 @@ const AlertReportModal:
FunctionComponent<AlertReportModalProps> = ({
ownState: {},
};
- const data = await getChartDataRequest(filterValues).then(response => {
- const rawData = response.json.result[0].data;
- let filteredData = rawData;
-
- if (vizType === 'filter_timecolumn') {
- // filter for time columns types
- filteredData = rawData.filter((item: any) => item.dtype === 2);
- }
+ const { response, json } = await getChartDataRequest(filterValues);
+ const queriesResponse = await handleChartDataResponse(response, json);
Review Comment:
Does just adding a catch take care of the async issue with GAQ? We want a
fix, not just a notification that the data was not returned.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
