codeant-ai-for-open-source[bot] commented on code in PR #43793:
URL: https://github.com/apache/superset/pull/43793#discussion_r3916258199
##########
superset-frontend/src/features/alerts/AlertReportModal.tsx:
##########
@@ -759,35 +762,35 @@ const AlertReportModal:
FunctionComponent<AlertReportModalProps> = ({
ownState: {},
};
- const data = await getChartDataRequest(filterValues).then(response => {
- const rawData = response.json.result[0].data;
- let filteredData = rawData;
-
- if (vizType === 'filter_timecolumn') {
- // filter for time columns types
- filteredData = rawData.filter((item: any) => item.dtype === 2);
- }
+ const { response, json } = await getChartDataRequest(filterValues);
+ const queriesResponse = await handleChartDataResponse(response, json);
Review Comment:
**Suggestion:** Async job failures reject here, but `addNativeFilterOptions`
does not catch this promise, producing an unhandled rejection instead of the
dashboard-filter error toast. [error handling]
**Assessment:** ๐ `Major` ยท ๐ `Occurrence: Sometimes`
[](https://docs.codeant.ai/cli/resolve-pr-comments-skill)
[](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=df3f21d48648423ca6cfb06cacce21c9&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
[](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=df3f21d48648423ca6cfb06cacce21c9&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
<details>
<summary><b>Prompt for AI Agent ๐ค </b></summary>
```mdx
This is a comment left during a code review.
**Path:** superset-frontend/src/features/alerts/AlertReportModal.tsx
**Line:** 766:766
**Comment:**
*Error Handling: Async job failures reject here, but
`addNativeFilterOptions` does not catch this promise, producing an unhandled
rejection instead of the dashboard-filter error toast.
Validate the correctness of the flagged issue. If correct, How can I resolve
this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask
user if the user wants to fix the rest of the comments as well. if said yes,
then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
<a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F43793&comment_hash=b9906c285bab9826bbafdb5dc01fa31b5d60ea0daad144f35772b6e0ea88c5a4&reaction=like'>๐</a>
| <a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F43793&comment_hash=b9906c285bab9826bbafdb5dc01fa31b5d60ea0daad144f35772b6e0ea88c5a4&reaction=dislike'>๐</a>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
