villebro commented on PR #43843: URL: https://github.com/apache/superset/pull/43843#issuecomment-5543702413
Cleaned up the two non-blocking follow-ups in ba27915: - `superset-websocket/utils/loadtest.js` no longer hardcodes `realtime` — it now builds `<prefix>realtime`, resolving the prefix the same way the server does (`REALTIME_CHANNEL_PREFIX` env, else `config.json`'s `realtimeChannelPrefix`, else empty), so a loadtest can exercise a prefixed server. - Fixed the stale "single `realtime` channel" JSDoc on `subscribeToChannels` to say `<REALTIME_CHANNEL_PREFIX>realtime`. `npm run lint` (eslint + tsc) and pre-commit are green. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
