sha174n commented on code in PR #43020:
URL: https://github.com/apache/superset/pull/43020#discussion_r3968002947
##########
superset/db_engine_specs/lib.py:
##########
@@ -169,7 +165,7 @@ def diagnose(spec: type[BaseEngineSpec]) -> dict[str, Any]:
"query_cost_estimation": has_custom_method(spec,
"estimate_query_cost")
or has_custom_method(spec, "estimate_statement_cost"),
# SQL validation is implemented in external classes
- "sql_validation": spec.engine in sql_validators,
+ "sql_validation": spec.engine in SQL_VALIDATION_ENGINES,
Review Comment:
Fixed in daa3cac. The Aurora PostgreSQL (Data API) rows now read 94 and SQL
Validation False, matching diagnose(). I applied it as a delta rather than
regenerating the whole file: the checked-in snapshot has unrelated drift from
master (missing engines, other score changes), and a full regen would bury this
change in it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
