sha174n commented on PR #43020:
URL: https://github.com/apache/superset/pull/43020#issuecomment-5656448729
@rusackas Thanks, that's the missing piece. Added
`@pytest.mark.sql_json_flow` to the four tests in b9307dc; they're now
collected by `test-postgres-presto` (`-m 'chart_data_flow or sql_json_flow'`
picks up 4 in that file, previously 0).
Running them for real surfaced one that would have failed.
`test_validate_sql_with_jinja_templates_and_params` filtered on `city`, which
`birth_names` doesn't have. That was inert under pgsanity's syntax-only check,
but `EXPLAIN (TYPE VALIDATE)` resolves columns, so it returns an annotation and
breaks the `len(result) == 0` assertion. Both jinja tests now filter on
`state`, and all four declare
`@pytest.mark.usefixtures("load_birth_names_data")` so they don't depend on
another module in the job having loaded the table. Fixed in 9c94c59.
Also picked up bito's `in {'presto'}` vs `== 'presto'` nit in the docs
generator there.
Rebased on master, the UPDATING.md conflict is resolved and the PR shows
mergeable again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
