sha174n commented on PR #43020: URL: https://github.com/apache/superset/pull/43020#issuecomment-5601370209
@rusackas @sadpandajoe One more in daa3cac: - `db_engine_specs/README.md` capability matrix: the Aurora PostgreSQL (Data API) rows still read score 104 / SQL Validation True. Now 94 / False, matching `diagnose()`. Applied as a two-line delta, not a full regen: that snapshot has unrelated drift from master (engines it is missing, other score changes) that would swamp this PR. - Sync comments in `lib.py` and the docs generator now name the `SQL_VALIDATORS_BY_ENGINE` default in `superset/config.py` as the source of truth. I tried deriving `SQL_VALIDATION_ENGINES` from it instead of restating it, and backed that out: importing `superset.config` from `lib.py` executes the operator `superset_config.py` on every import of a module the CLI walks eagerly, which it does not do today. The reason is recorded in the comment. - Qualified the validation prose, the SQLite validator is opt-in and needs `syntaqlite`, which is why the tables report it unsupported. - The serialization unit test now also asserts the validator receives the *rendered* SQL, which covers the jinja-renders-to-invalid-SQL guard that lost its integration counterpart. Still open and yours to call: the four remaining `validate_sql` integration tests are presto-gated and no CI job runs this file against a Presto example DB, so they skip everywhere. Mark them for the presto job, drop them, or leave as-is, here or in a follow-up. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
