sha174n commented on PR #43060: URL: https://github.com/apache/superset/pull/43060#issuecomment-5608901437
Pushed ab9f341b77, with current master merged in again. CI was red on the 100% coverage gate for `superset/sql/`: the fail-closed branches for an `EXPLAIN ANALYZE` body that cannot be classified had no test of their own, so they are covered now. Same commit de-duplicates the helpers that grew out of the earlier rounds: the `EXPLAIN ANALYZE` body classification is now shared between `is_mutating` and `changes_search_path` rather than copied into each, and the opaque-`SET` leading-setting-name scan is shared between `changes_search_path` and `changes_default_schema`. Also folded the parenthesized and bare spellings of the option list into one flag search, and dropped the `noqa: C901` on `is_mutating` that the extraction made unnecessary. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
