sha174n commented on PR #43060: URL: https://github.com/apache/superset/pull/43060#issuecomment-5617843971
Pushed 441d31241f, with current master merged in. Another pass over the diff: the isinstance / head-keyword / body-text triple that each gate spelled out for itself is now two shared accessors (`_command_head`, `_nested_body_text`), so a gate can't quietly opt out of a branch by omitting the case fold. Three behaviour changes fell out of that: - a nested body matches a qualifier between `SET` and the setting name (`SET LOCAL SCHEMA 'x'`), as the non-nested path already did; - `RESET search_path` / `RESET ALL` count as a rebind, since the restored default need not be the schema the caller selected; - `changes_default_schema` recurses through an `EXPLAIN ANALYZE` wrapper rather than deferring to `changes_search_path`, so its own `SET SCHEMA` / `SET CATALOG` forms are visible inside one. New cases for each in `test_changes_search_path` and `test_changes_default_schema`; `superset/sql/` still at 100% coverage. The one red check on the previous commit was `playwright-tests-experimental`, which timed out fetching `uv` in its Setup Python step, before any test ran. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
