aminghadersohi commented on PR #43737: URL: https://github.com/apache/superset/pull/43737#issuecomment-5658741970
@rusackas You're right. On September 11 at 14:08:32 UTC I force-pushed `072bdea74eb0` → `eb9000877482`, replacing the history with one commit atop master `774a51124ed3`. My earlier “no force push” replies described the earlier pushes, but are **not true of the branch's subsequent history**; I should have updated that record. I aborted an initial commit-by-commit rebase because reviewed fixes also lived in merge commits. I then chose to snapshot the complete `072bdea74eb0` tree, squash it against its merge-base `e5c2a3e4f682`, rebase that snapshot onto master, and push with an explicit lease on the old head. Squashing was my choice, not a requirement of rebasing; the lease guarded the remote head, not review validity. Audit against the actual approved commits (`1614ed40238e`, `924100c73c46`, and `072bdea74eb0`): - Reconstructing a merge of the last approved tree with `774a51124ed3` reproduces **the entire current tree exactly**, after resolving only two chart-type-list docstring conflicts to retain both Gantt and Treemap. - Gantt implementation/tests, shared query helpers, preview/compile, and both update tools are byte-identical to the last approved head. Named default-preview validation/typo rejection, invalid-row skipping and payload cap, mixed-series ordering, omitted controls, strict rebinds, native temporal filters, and empty time bounds remain covered. - Relative to the earlier approvals, two generic cached-filter tests had already been renamed/changed during the September 10 upstream merge to preserve user temporal filters; Gantt-specific reconciliation regressions were added separately. These changes predate the final approval, not the squash. No chart test functions from the last approved head were lost. Fresh validation: **1,824 chart tests passed; 4,271 broad MCP/common-query tests passed, 1 skipped**. Full PR-delta pre-commit (including MyPy/Ruff/Pylint/workflow security), Python compilation, and diff checks passed. **All 13 required checks are green with workflow head SHAs verified as `eb90008774828be54dacc894a7da5de74564265f`** ([checks](https://github.com/apache/superset/pull/43737/checks)). No regression found; no code/history changes in this audit. Local app health is unavailable, so this is not a new live UI verification. I've requested fresh human reviews from @rebenitez1802, @sadpandajoe, and @gabotorresruiz. Their earlier approvals were against replaced history, not this head; green CI is not a substitute for that review. No approval was dismissed or recreated. The PR remains open and non-draft. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
