bito-code-review[bot] commented on PR #44286: URL: https://github.com/apache/superset/pull/44286#issuecomment-5675899904
<!-- Bito Reply --> The flagged issue is correct. The current dependency definition in `pyproject.toml` uses `databricks-sqlalchemy>=2.0.1, <3`, which correctly restricts the version to the 2.x series. However, the documentation in `UPDATING.md` and `superset/db_engine_specs/databricks.py` states "2.0.1 or later," which implies support for 3.x and beyond, creating a mismatch with the actual package constraints. To resolve this, update the documentation to explicitly mention the supported version range. Would you like me to implement this change across the documentation files, and would you like me to check the rest of the PR comments for other issues? **UPDATING.md** ``` - The Databricks extra requires databricks-sqlalchemy 2.0.1 or later (up to 3.x). The 1.x dialect requires SQLAlchemy below 2. ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
