aminghadersohi commented on code in PR #44286: URL: https://github.com/apache/superset/pull/44286#discussion_r4018790019
########## UPDATING.md: ########## @@ -24,6 +24,8 @@ assists people when migrating to a new version. ## Next +- The Databricks extra requires databricks-sqlalchemy 2.0.1 or later. The 1.x dialect requires SQLAlchemy below 2. Review Comment: Fixed in 822336d19a4baf6789623807b89d94a104704534. UPDATING.md, the Databricks engine metadata, and docs/src/data/databases.json all say “databricks-sqlalchemy 2.x (at least 2.0.1),” matching the >=2.0.1,<3 extra. Scoped pre-commit (all five branch-changed files, including mypy/Ruff/pylint/metadata validation) passed. The focused real-dialect suite passed: 65 tests with SQLAlchemy 2.0.52, dialect 2.0.1, connector 4.5.0, and greenlet 3.5.5. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
