bito-code-review[bot] commented on PR #44265: URL: https://github.com/apache/superset/pull/44265#issuecomment-5680511105
<!-- Bito Reply --> The observation regarding `filters[].col` is correct. Since these columns are validated against `valid_columns` and mapped to provider `Dimension`s, they require the same join logic as other dimensions to ensure compatibility with metrics. Without this, filters on incompatible dimensions will indeed fail downstream without proper validation. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
