mikebridge commented on PR #44265: URL: https://github.com/apache/superset/pull/44265#issuecomment-5708968250
Addressed https://github.com/apache/superset/pull/44265#discussion_r4015790697 in e57564e789eca564c24beaee76f4c55e070d6436: compatibility uses selected dimensions plus filters[].col, including requests with no grouping dimensions. Invalid filter dimensions fail ValidationError before build/execute; a compatible filter-only request still executes with its filter intact. Bito's two dead mock return setups in the skip test were also removed. Two new rejection cases fail before the fix; final scoped suite:48passed. Full-branch Python/semantic review and applicable file-scoped hooks (including MyPy) pass. A manually composed snapshot with #44270's grain remediation passes5targeted checks and preserves view plus grain_column/valid_grains/temporal_columns. This is integrated fixture evidence; whichever PR lands second still needs final merge reconciliation. Fresh CI/reviewer confirmation remains, and no thread was auto-resolved. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
