sadpandajoe commented on code in PR #44250:
URL: https://github.com/apache/superset/pull/44250#discussion_r4021462175
##########
.github/workflows/tag-release.yml:
##########
@@ -55,8 +55,7 @@ jobs:
contents: write
strategy:
matrix:
- build_preset:
- ["superset", "dev", "lean", "websocket", "dockerize", "py311",
"py312"]
+ build_preset: ["superset", "dev", "lean", "py311", "py312"]
Review Comment:
The helper now runs only after the job checks out the release ref, so every
existing 6.x ref lacks it and 7.0 still requires the second image-tag argument;
the step exits before Supersetbot and publishes no images. Could the workflow
snapshot the current helper before switching refs, while still reading the
release Dockerfile, and exercise that ref swap in the command check?
##########
.github/workflows/docker.yml:
##########
@@ -162,15 +226,27 @@ jobs:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
BUILD_PRESET: ${{ matrix.build_preset }}
run: |
- # Single platform builds in pull_request context to speed things up
- if [ "$GITHUB_EVENT_NAME" = "push" ]; then
+ set -euo pipefail
+ BUILD_CONTEXT="$GITHUB_EVENT_NAME"
+ BUILD_CONTEXT_REF=""
+ PUBLISH_DOCKER_CACHE=""
+
+ if [ "$GITHUB_EVENT_NAME" = "push" ] && [ "$GITHUB_REF" =
"refs/heads/master" ]; then
PLATFORM_ARG="--platform linux/arm64 --platform linux/amd64"
- # can only --load images in single-platform builds
PUSH_OR_LOAD="--push"
Review Comment:
Branch-level cancellation prevents tag rollback, but any later master
push—including one whose Docker job is skipped by change detection—cancels the
active publisher, leaving that SHA’s unfinished preset tags missing and the
mutable `master*` presets split across commits. Could publishing be queued or
tip-guarded instead of allowing a non-publishing run to cancel it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
