sadpandajoe commented on code in PR #44250:
URL: https://github.com/apache/superset/pull/44250#discussion_r4034724760
##########
UPDATING.md:
##########
@@ -71,6 +71,20 @@ but under `-lean` tags: `latest-lean`, `master-lean`,
`5.0.0-lean`, `<sha>-lean`
drivers most installations need are now present out of the box.
- The `-dev` images (`latest-dev`, `master-dev`, …) are unchanged.
+### Docker image publishing now excludes standalone `websocket` and
`dockerize` images
+
+The Apache Superset Docker Hub repository no longer publishes standalone
+`apache/superset:*websocket` or `apache/superset:*dockerize` image tags. The
+realtime WebSocket server is bundled in the `superset`, `lean`, and `dev`
images
+and can be launched with `/app/docker/entrypoints/run-websocket.sh`. Helm init
+containers use the main Superset image for dependency checks.
+
+Release branch pushes no longer publish Docker Hub images or cache layers; they
Review Comment:
GitHub runs `push` and `release` workflows from the event ref, so merging
this only into `master` leaves the current `6.0`, `6.1`, and `7.0` branches on
their old publishers: branch pushes still use `--push`, and tagged releases
still publish the retired preset matrix. Can this policy be backported or
otherwise gated before claiming release-branch publishing has stopped?
##########
.github/workflows/tag-release.yml:
##########
@@ -104,13 +109,17 @@ jobs:
fi
git checkout "${INPUT_GIT_REF}"
EVENT="release"
+ else
+ git checkout "${GITHUB_EVENT_RELEASE_TAG_NAME}"
fi
+ EXTRA_FLAGS="$(bash "$RUNNER_TEMP/docker-build-extra-flags.sh"
"$BUILD_PRESET")"
Review Comment:
This reuses the CI helper for release rebuilds, and that helper
unconditionally adds `INCLUDE_CHROMIUM=false`; manually rebuilding `5.0.0`
changes its Dockerfile default from `true` and republishes the same tag without
Playwright/Chromium. Should the release path preserve the checked-out tag’s
browser default instead of applying the CI-only flag?
##########
.github/workflows/docker.yml:
##########
@@ -162,15 +226,27 @@ jobs:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
BUILD_PRESET: ${{ matrix.build_preset }}
run: |
- # Single platform builds in pull_request context to speed things up
- if [ "$GITHUB_EVENT_NAME" = "push" ]; then
+ set -euo pipefail
+ BUILD_CONTEXT="$GITHUB_EVENT_NAME"
+ BUILD_CONTEXT_REF=""
+ PUBLISH_DOCKER_CACHE=""
+
+ if [ "$GITHUB_EVENT_NAME" = "push" ] && [ "$GITHUB_REF" =
"refs/heads/master" ]; then
PLATFORM_ARG="--platform linux/arm64 --platform linux/amd64"
- # can only --load images in single-platform builds
PUSH_OR_LOAD="--push"
Review Comment:
GitHub keeps only one pending run per concurrency group, so a third master
push replaces the already-pending publisher; if that third push is docs-only,
the pending commit’s SHA images are never produced and the `master*` tags stay
stale. Could this use a full queue or scope serialization after change
detection?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
