villebro commented on code in PR #44250:
URL: https://github.com/apache/superset/pull/44250#discussion_r4039155801
##########
UPDATING.md:
##########
@@ -71,6 +71,20 @@ but under `-lean` tags: `latest-lean`, `master-lean`,
`5.0.0-lean`, `<sha>-lean`
drivers most installations need are now present out of the box.
- The `-dev` images (`latest-dev`, `master-dev`, …) are unchanged.
+### Docker image publishing now excludes standalone `websocket` and
`dockerize` images
+
+The Apache Superset Docker Hub repository no longer publishes standalone
+`apache/superset:*websocket` or `apache/superset:*dockerize` image tags. The
+realtime WebSocket server is bundled in the `superset`, `lean`, and `dev`
images
+and can be launched with `/app/docker/entrypoints/run-websocket.sh`. Helm init
+containers use the main Superset image for dependency checks.
+
+Release branch pushes no longer publish Docker Hub images or cache layers; they
Review Comment:
Agreed. We will land this on master first and cherry-pick the policy into
active release branches afterward. I updated UPDATING.md and the PR description
to state explicitly that existing release branches retain their old publishing
workflows until those backports land, rather than claiming this master PR
changes them.
##########
.github/workflows/tag-release.yml:
##########
@@ -104,13 +109,17 @@ jobs:
fi
git checkout "${INPUT_GIT_REF}"
EVENT="release"
+ else
+ git checkout "${GITHUB_EVENT_RELEASE_TAG_NAME}"
fi
+ EXTRA_FLAGS="$(bash "$RUNNER_TEMP/docker-build-extra-flags.sh"
"$BUILD_PRESET")"
Review Comment:
Fixed in 9165f06627. Release builds invoke the shared helper in release
mode, which leaves INCLUDE_CHROMIUM at the checked-out Dockerfile default; CI
validation retains its explicit false override. I checked the helper with the
5.0.0 Dockerfile and it emits PY_VER=3.11.13-slim-bookworm without a Chromium
override. The Docker command check now asserts that release commands contain no
INCLUDE_CHROMIUM build arg.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
