mikebridge commented on PR #44270: URL: https://github.com/apache/superset/pull/44270#issuecomment-5708967710
Addressed the two grain-validation findings in 03ed7c6b5cc39ef8b4b03cd9e22517b1b72a1ad7: - https://github.com/apache/superset/pull/44270#discussion_r4014745825 — validate against the selected column's provider variants; a view-wide MONTH capability no longer permits MONTH on a DAY/YEAR-only signup_date. Both explicit and inferred column cases are covered. - https://github.com/apache/superset/pull/44270#discussion_r4014745830 — use the selected grain axis for granularity and the time-range filter when time_column is inferred. The regression checks both BASE_AXIS and actual TEMPORAL_RANGE filter placement. Three added cases fail on the previous implementation; final scoped get_table/response suites:61passed. Full-branch Python/semantic review and all applicable file-scoped hooks (including MyPy) pass. A manually composed fixture with #44265's filter fix passes5targeted checks and preserves both resolver contracts; the second PR to land still needs final merge reconciliation. https://github.com/apache/superset/pull/44270#discussion_r4014745835 and Bito's temporal-vocabulary note remain **open contract disposition**, not silently fixed. Existing datetime output/tests are preserved in this follow-up. Fresh CI/reviewer confirmation remains; no thread was auto-resolved. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
