codeant-ai-for-open-source[bot] commented on code in PR #44270:
URL: https://github.com/apache/superset/pull/44270#discussion_r4033310599
##########
superset/mcp_service/semantic_layer/tool/get_table.py:
##########
@@ -264,7 +342,18 @@ def _build_response(
warnings=warnings,
)
- columns_meta = format_data_columns(data, raw_columns)
+ # Semantic views return grain variants as <temporal dimension>__<grain>.
+ result_temporal_columns: set[str] = {
+ name
+ for name in raw_columns
+ if any(
+ name == base or name.startswith(f"{base}__")
+ for base in temporal_columns or set()
+ )
+ }
Review Comment:
**Suggestion:** Any result column beginning with a temporal column name is
marked `datetime`, including unrelated dimensions or metrics such as
`date__label`.
**Assessment:** ๐ `Major` ยท ๐ `Occurrence: Sometimes` ยท ๐ท๏ธ `Incorrect
condition logic`
[](https://docs.codeant.ai/cli/resolve-pr-comments-skill)
[](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=9139fd88cc0a4725b7e707d33c7d5ecc&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
[](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=9139fd88cc0a4725b7e707d33c7d5ecc&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
<details>
<summary><b>Prompt for AI Agent ๐ค </b></summary>
```mdx
This is a comment left during a code review.
**Path:** superset/mcp_service/semantic_layer/tool/get_table.py
**Line:** 346:353
**Comment:**
*Incorrect Condition Logic: Any result column beginning with a temporal
column name is marked `datetime`, including unrelated dimensions or metrics
such as `date__label`.
Validate the correctness of the flagged issue. If correct, How can I resolve
this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask
user if the user wants to fix the rest of the comments as well. if said yes,
then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
<a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F44270&comment_hash=bc903e0cf0243665ce453e641427f1bf12674e8b5214ab9acc76f41b86037dee&reaction=like'>๐</a>
| <a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F44270&comment_hash=bc903e0cf0243665ce453e641427f1bf12674e8b5214ab9acc76f41b86037dee&reaction=dislike'>๐</a>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
