mikebridge commented on code in PR #44270:
URL: https://github.com/apache/superset/pull/44270#discussion_r4042114702
##########
superset/mcp_service/utils/response_utils.py:
##########
@@ -195,6 +200,8 @@ def format_data_columns(
data_type = "boolean"
elif all(isinstance(v, (int, float)) for v in sample_values):
data_type = "numeric"
+ if temporal_columns and col_name in temporal_columns:
+ data_type = "datetime"
Review Comment:
Confirmed: the same DataColumn field is `temporal` in get_chart_data and
`datetime` here. Decision: get_table adopts the existing `temporal` vocabulary
— one contract across tools, no consumer change. Follow-up commit on this PR
with the tests updated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
