aminghadersohi commented on PR #44386: URL: https://github.com/apache/superset/pull/44386#issuecomment-5753402637
@rebenitez1802 Thanks for both approval reviews! Addressed the three nits in 5763594911: over-budget mocks now return 600 on every call, with corrected comments and an already-fits preservation test; opaque ToolResult coverage now includes get_chart_sql and execute_sql, asserting ToolError without dumping the wrapper; and a one-line comment documents the success fallback assumption. All 239 affected tests and branch-scoped pre-commit checks pass. No review re-requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
