aminghadersohi commented on PR #44386: URL: https://github.com/apache/superset/pull/44386#issuecomment-5756204966
Reply to [Bito's 2026-09-17 review body, “Marker registry bypassed”](https://github.com/apache/superset/pull/44386#pullrequestreview-5241831844): **valid consistency finding**, addressed in 83f1ebcbc43b6de1d41c2f3dd6c873065a150780. `truncate_query_result`'s CSV fallback now passes `suffix_marker=_STRING_FIELD_TRUNCATION_MARKERS.get("csv_data", "")` to `_truncate_named_string_field`, matching `truncate_string_field_response`. There is no default CSV marker change. The CSV regression test covers both an empty registry marker and a configured non-empty marker, asserting the latter survives truncation and the complete response stays within its token budget. Affected tests: 251 passed. Staged/branch-scoped pre-commit and explicit mypy passed. This is body-only feedback with no associated unresolved thread; this linked reply records it as addressed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
