aminghadersohi commented on PR #44386: URL: https://github.com/apache/superset/pull/44386#issuecomment-5756205155
Reply to [Bito's 2026-09-18 review body, “changed_fields list dropped”](https://github.com/apache/superset/pull/44386#pullrequestreview-5248502306): **valid**, addressed in 83f1ebcbc43b6de1d41c2f3dd6c873065a150780. `UpdateDashboardResponse.changed_fields` is a string list, and `_select_confirmation_fields` previously dropped it despite the docstring's claim. The selector now retains string lists only when bounded by both **20 items** and **200 total characters**. Oversized, mixed-type, and nested lists remain omitted. The docstrings and MCP configuration documentation describe this accurately; regression tests cover empty/short lists, exact bounds, each exceeded bound, nested/mixed values, and a dashboard minimal fallback retaining `["css"]`. Affected tests: 251 passed. Staged/branch-scoped pre-commit and explicit mypy passed. This is body-only feedback with no associated unresolved thread; this linked reply records it as addressed. The separate restore/delete identity finding remains disproved and closed; it is not being reopened. AC 3 remains PARTIAL and AC 6 remains post-deploy verification. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
