sha174n commented on PR #44080: URL: https://github.com/apache/superset/pull/44080#issuecomment-5766259624
@rusackas one tidy-up pass on top in 755e76d, no behaviour change to the rule you flagged: the two conversion clauses fold into a single condition, the requested schema/catalog are normalised at construction so the same value is compared and authorised, and the virtual test reuses the existing `BaseDatasource.is_virtual` property instead of re-deriving it from `sql`. Tests unchanged in substance and still green. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
