sha174n commented on PR #44080: URL: https://github.com/apache/superset/pull/44080#issuecomment-5768014907
@rusackas quality pass in 4449a33, no change to the rule you flagged: the requested and current targets are now two `Table` values compared with `dataclasses.astuple` (`Table.__eq__` compares the dotted rendering, which would conflate distinct targets), the gate reads as two named predicates instead of a negation nested in the condition, and the repeated per-test scaffolding moves into a dataset factory plus a save helper, with the three "must not re-check" cases folded into one parametrized test. Verified by mutating the gate both ways: forcing it on fails the skip cases, restricting it to database-only fails the repoint cases. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
