sha174n commented on PR #44080: URL: https://github.com/apache/superset/pull/44080#issuecomment-5770766984
@rusackas both points are in already: the omitted-key read in d16ddd8, and the non-dataset guard in 5ce70d6 (`isinstance(orm_datasource, SqlaTable)` short-circuits, so `table_name`/`is_virtual` are never read on a query or semantic view, covered by `test_save_of_non_dataset_datasource_skips_table_check`). One follow-up in b05b995 from a tidy-up pass, no behaviour change: the "result is still virtual" skip moved out of the helper and into the caller's `and` chain, so `_repoints_table` takes two arguments and answers one question. The red CI here is not from this branch: `babel-extract` and the `check_pot_drift` unit test both fail on `messages.pot` drift for strings in `superset/dashboards/api.py` and the report/screenshot paths, which reproduces on master. This PR adds no translatable strings. Everything else is green (17211 passed). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
