sha174n commented on PR #44496: URL: https://github.com/apache/superset/pull/44496#issuecomment-5775582218
Pushed b88e209, which corrects two problems in the nested-body comment strip. A dollar-quoted region is now unwrapped only when the statement head introduces it: a `DO` block, or a region running to the end of the body. One that stops short of the end is an ordinary argument, and unwrapping it exposed its contents as code, so a `--` inside `CALL p($q$--$q$, ...)` commented out the rest of the body and hid it from this gate and from the two pre-existing ones that scan the same text. Separately, `--` now only opens a comment on MySQL-family dialects when whitespace follows, since `1--2` is arithmetic there. Both cases are pinned by tests. Closing delimiters are also matched by search rather than a backtracking regex, which rescanned to end of text from every opener that had none: a 31 KB body went from 373 ms to 2 ms, and scaling is linear. @aminghadersohi the `messages.pot` change is a regeneration, not new strings: master is currently out of sync with source by 5 strings plus 4 stale ones, and the babel-extract and unit-test gates fail until the template is rebuilt, so the rebuild picks those up alongside this branch's one new message. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
