sha174n commented on PR #44496: URL: https://github.com/apache/superset/pull/44496#issuecomment-5777342696
Addressed in 8ae0fb7 — the string-literal half of this was still open. Comments were being stripped around literals but not inside them, so a comment wedged into a quoted body (`EXECUTE IMMEDIATE 'PUT/*x*/file:///tmp/a @s'`) split the head from its argument and the scan missed it, while the dollar-quoted spelling of the same statement was caught. A literal is what a nested body actually executes, so its interior is now stripped too. Rescanning only the interior is what keeps that safe: a `--` inside a literal can blank the rest of that literal but never reaches past the closing delimiter, so the existing "`--` in a literal must not truncate the statements after it" cases still hold. Recursion is bounded so deeply nested `$tag$` regions cannot exhaust the stack. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
