rusackas commented on PR #44496: URL: https://github.com/apache/superset/pull/44496#issuecomment-5802013726
Went back through everything since my approval: the nested-body scan, the comment strip with the dollar-quote peel and the MySQL spaced `--` rule, the gate on the estimate and alert paths, and the cached body. All looks sound to me, and the test matrix on it is thorough. Still LGTM. @aminghadersohi your mutation pass predates all of the strip logic, so I'd love your eyes on `_strip_comments` before this merges... mostly whether hand-rolling that lexing beats leaning on sqlglot's tokenizer, which already knows the per-dialect comment and `$$` rules. Also, GitHub shows conflicts on `UPDATING.md` and `messages.pot` now, so this needs one more pass on `master`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
