sadpandajoe commented on code in PR #44543:
URL: https://github.com/apache/superset/pull/44543#discussion_r4076800054


##########
.asf.yaml:
##########
@@ -77,6 +77,7 @@ github:
         # combination here.
         contexts:
           - lint-check
+          - babel-extract

Review Comment:
   This can be satisfied by a successful `babel-extract` run that predates 
`check_pot_drift.py`: with `strict: false`, an older PR such as #44397 still 
has a Sept. 17 success for this context and can merge without running the drift 
check. Could we require a fresh context (or make the required checks strict) so 
older heads cannot bypass the new gate?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to