rusackas commented on code in PR #44543:
URL: https://github.com/apache/superset/pull/44543#discussion_r4077264553
##########
.asf.yaml:
##########
@@ -77,6 +77,7 @@ github:
# combination here.
contexts:
- lint-check
+ - babel-extract
Review Comment:
You're right, and bito's reply above is wrong on this one. Required status
checks are evaluated per commit SHA, not per
workflow-definition-at-time-of-run, GitHub just checks whether a passing status
with that context name already exists on the head SHA. An old PR whose head
hasn't moved since before `check_pot_drift.py` existed would have exactly that,
a stale but genuinely-passing `babel-extract` status on record, and nothing
here forces a fresh run to satisfy it. That's what `strict: true` is for, and
it's why I split it out as #44544 instead of bundling it in here. Left this one
narrower on purpose, but agreed the gap stays open until that one lands too,
want to land them together rather than merge this alone and forget the
follow-up.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
