bito-code-review[bot] commented on PR #44581: URL: https://github.com/apache/superset/pull/44581#issuecomment-5800500640
<!-- Bito Reply --> The flagged issue is correct. Synchronous tools currently execute on the transport thread, which can block the MCP server if they perform long-running warehouse operations. To resolve this, you should wrap synchronous tool calls in `run_in_worker` to offload them to a worker thread, similar to how asynchronous tools are handled. Would you like me to fetch all other comments on this PR to validate and implement fixes for them as well? **superset/mcp_service/auth.py** ``` from superset.mcp_service.worker import run_in_worker # Wrap synchronous tool execution: # result = await run_in_worker(sync_tool_func, args, kwargs, timeout) ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
