codeant-ai-for-open-source[bot] commented on code in PR #44581:
URL: https://github.com/apache/superset/pull/44581#discussion_r4085843716
##########
superset/mcp_service/auth.py:
##########
@@ -1259,7 +1277,27 @@ async def async_wrapper(*args: Any, **kwargs: Any) ->
Any:
_cleanup_session_on_error()
raise
- wrapper = async_wrapper
+ @functools.wraps(tool_func)
+ async def worker_wrapper(*args: Any, **kwargs: Any) -> Any:
+ from superset.mcp_service.worker import run_in_worker
+
+ bound = _tool_sig.bind_partial(*args, **kwargs)
+ request = bound.arguments.get("request")
+ seconds = getattr(request, "timeout", None)
+ if seconds is None:
+ if has_app_context():
+ seconds = current_app.config.get("SQLLAB_TIMEOUT", 30)
+ else:
+ from superset.mcp_service.flask_singleton import
get_flask_app
+
+ seconds = get_flask_app().config.get("SQLLAB_TIMEOUT", 30)
+ # Bind ctx once on the transport loop, including positional
callers.
+ bound.arguments.update(_inject_ctx(dict(bound.arguments)))
+ return await run_in_worker(
+ async_wrapper, (), dict(bound.arguments), seconds
+ )
+
+ wrapper = worker_wrapper
Review Comment:
**Suggestion:** Only async protected functions use `run_in_worker`;
protected synchronous tools still execute directly on the transport thread and
can freeze MCP while warehouse calls block.
**Assessment:** ๐ด `Critical` ยท ๐ `Occurrence: Sometimes` ยท ๐ท๏ธ `Incomplete
implementation`
[](https://docs.codeant.ai/cli/resolve-pr-comments-skill)
[](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=e36f7a05504e43d0b026dfdd1eb341d3&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
[](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=e36f7a05504e43d0b026dfdd1eb341d3&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
<details>
<summary><b>Prompt for AI Agent ๐ค </b></summary>
```mdx
This is a comment left during a code review.
**Path:** superset/mcp_service/auth.py
**Line:** 1300:1300
**Comment:**
*Incomplete Implementation: Only async protected functions use
`run_in_worker`; protected synchronous tools still execute directly on the
transport thread and can freeze MCP while warehouse calls block.
Validate the correctness of the flagged issue. If correct, How can I resolve
this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask
user if the user wants to fix the rest of the comments as well. if said yes,
then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
<a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F44581&comment_hash=65ddad2d3b1ef5babaed6ed147ba3cdbf91a484595541c8c6949d3ff9771eedd&reaction=like'>๐</a>
| <a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F44581&comment_hash=65ddad2d3b1ef5babaed6ed147ba3cdbf91a484595541c8c6949d3ff9771eedd&reaction=dislike'>๐</a>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
