codeant-ai-for-open-source[bot] commented on code in PR #44581:
URL: https://github.com/apache/superset/pull/44581#discussion_r4085849128
##########
superset/models/core.py:
##########
@@ -602,35 +602,38 @@ def get_sqla_engine( # pylint: disable=too-many-arguments
sqlalchemy_uri=sqlalchemy_uri,
cacheable=not prequeries,
)
- if prequeries:
- # SQLAlchemy connect event: runs prequeries on every
new
- # DBAPI connection (e.g. SET search_path for
PostgreSQL).
- def run_prequeries(
- dbapi_connection: Any,
- connection_record: Any, # pylint:
disable=unused-argument
- ) -> None:
- cursor = dbapi_connection.cursor()
+ from superset.sql.execution.cancellation import
cancellable_engine
+
+ with cancellable_engine(self, engine, catalog, schema):
+ if prequeries:
+ # SQLAlchemy connect event: runs prequeries on
every new
+ # DBAPI connection (e.g. SET search_path for
PostgreSQL).
+ def run_prequeries(
+ dbapi_connection: Any,
+ connection_record: Any, # pylint:
disable=unused-argument
+ ) -> None:
+ cursor = dbapi_connection.cursor()
+ try:
+ for prequery in prequeries:
+ cursor.execute(prequery)
Review Comment:
**Suggestion:** Prequeries execute through a raw DBAPI cursor before
cancellation registration, so a blocking prequery can exceed the MCP deadline
without cancellation.
**Assessment:** ๐ `Major` ยท ๐ `Occurrence: Sometimes` ยท ๐ท๏ธ `Incomplete
implementation`
[](https://docs.codeant.ai/cli/resolve-pr-comments-skill)
[](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=691f8c603af04edf8fc2d4e6ce0412e0&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
[](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=691f8c603af04edf8fc2d4e6ce0412e0&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
<details>
<summary><b>Prompt for AI Agent ๐ค </b></summary>
```mdx
This is a comment left during a code review.
**Path:** superset/models/core.py
**Line:** 617:618
**Comment:**
*Incomplete Implementation: Prequeries execute through a raw DBAPI
cursor before cancellation registration, so a blocking prequery can exceed the
MCP deadline without cancellation.
Validate the correctness of the flagged issue. If correct, How can I resolve
this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask
user if the user wants to fix the rest of the comments as well. if said yes,
then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
<a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F44581&comment_hash=830896e61f12bca216429e7a9296c3c6df9c9204b8c0f2635b601587c1b81e3d&reaction=like'>๐</a>
| <a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F44581&comment_hash=830896e61f12bca216429e7a9296c3c6df9c9204b8c0f2635b601587c1b81e3d&reaction=dislike'>๐</a>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
