AmoghAtreya commented on code in PR #43176:
URL: https://github.com/apache/superset/pull/43176#discussion_r4174215784
##########
superset/common/tabular_query.py:
##########
@@ -397,6 +402,28 @@ def build_query_dict(
return query_dict
+def _time_range_from_filters(filters: Any) -> str | None:
Review Comment:
Resolved this as well - Renamed `_time_range_from_filters` to
`_temporal_range_in_filters` so it is harder to mix up with
`_time_range_filters`. Pushed in latest commit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
